Armor at Paragon and above

[Charlie]

Wow, thank you!    I think this is a keeper. One thing that I noticed was that when I was fixing my character that having the wrong level armor also gave me a "Multiple sets of armor equipped" error, but I certainly don't think that's a deal breaker.

Flagging the problem regardless of the order you build the armor in is a huge improvement. Thanks again!

[dracusmage]

I'll have to see if I can replicate that error, but I'm not quite as concerned about extra errors when there is a problem. I'm far more concerned with error messages when the right thing is happening or no errors when the wrong thing happens.

[dracusmage]

I can only get the multiple sets equipped error when I actually have multiple sets equipped. I've tried non-proficient armor, too low, to high, wrong enchantment type, but nothing is causing an extra error (beyond when I combine errors like low level armor, with incompatible enchantments and no proficiency).

For example +5 Agile Resolve Vestments on Spiked Plate +11 gives an inferior armor error, and two errors for the enchantment - one telling me that it is the wrong kind of magic item, and one telling me that the enchantment is incompatible with the armor. Strange that it does that twice, but it's probably just checking from both ends. Not a problem, because the errors are both correct anyway, if redundant.

Can you send me a portfolio with a hero with the multiple sets error active?

[Charlie]

Sure, but it could be an artifact of other changes we've done to the files, and I agree that an extra error isn't that worrisome.

When I change the armor to the +8 version of Plate on my character, I see the extra error.

[dracusmage]

Your character threw an error about a missing rules file which orphaned something, but that wasn't the problem. All of the base level armors give that error. If you have any basic armor (Cloth +0, Leather +2, Plate +8, etc) all throw a multiple armors equipped error, both when they are enchanted and completely basic and not just for your character. It doesn't do anything foolish, like give a second bonus or something, so everything on the sheet is correct, but it still shouldn't throw an error like that.

I've done some testing and I know what is causing it, but I can't fix it without merging the armor fix into the ddi_armor.user file directly.

Because I wanted to make the lowest grade armors disappear I needed to add the max stat into them, so I did what works everywhere else; I copied them into the new file, changed the id to keep them unique, and added a "replaces" to designate that instead of the normal version the program should toss it away and use this one instead, using its name and everything.

For some reason, the system sees a "replaces" piece of armor twice. The validation code is in thing_validatation.data, but it's nothing complicated that could cause a problem that I can see:

Code Select Expand

  <!-- Armor thing for validation reporting -->
  <thing
    id="valArmor"
    name="Armor"
    compset="Simple">
    <tag group="Helper" tag="Bootstrap"/>

    <!-- Make sure that we don't have multiple sets of armor equipped -->
    <evalrule index="1" phase="Validate" priority="8000" message="Multiple suits of armor equipped"><![CDATA[
      ~if we have no more than one set of armor equipped, we're good
      if (hero.tagcount[Armor.?] <= 1) then
        @valid = 1
        done
        endif

      ~mark associaated tabs as invalid
      container.panelvalid[armory] = 0
      ]]></evalrule>

    </thing>

If we "debug the tags" of the armors, the basic ones load both the fixed version from the fix file, and also the old one without the max stat. arChainmai and arChainm1, for example. Not sure why. Possibly because the armors are both a type and an item so it deletes the replaced one as far as items go, but loads it when the armor is loaded? I dunno. But putting the max stat into the version that is already in the ddi_armor.user file and removing the "1" level in the fix file makes this issue go away.

[Charlie]

Thank you again! Since we've been concentrating on bug fixes in our group, I just went and put the new higher level armor variants into the ddi_armor.user file along with fixing the base levels.

By the way, I think you missed the base level of Studded Level in your file. I knew that Studded Leather was supposed to match Hide Armor, so it's fixed in our copy.

[dracusmage]

At this point putting fixes directly into the data files is the right way to do it. When we were still scraping for the data and any month might mean you would be generating all new data files due to a new book or errata having the fixes in external files meant you didn't have to keep fixing the same issues. We are so far past needing to scrape that there is little reason to use a one-off file other than you don't need to do the manual additions and a package update is a long time coming.

This is why I've just started pushing for a source control system to maintain the changes. I don't have the time to go though this forum and find every fix and manually integrate them and generate a new update, and the fact that we are almost a year past the last update pack shows that that's too much time and work for anyone else to do either.

I may not upload a fixed version with Studded Leather, but I probably will integrate it into my source tree.

[dracusmage]

Some of the fixes for equipment.str need to be placed in editor.dat to make it possible for people who don't love straight-up xml editing to change/view/create the correct field in armors to limit the magic.

I'm not fixing it right now, I just wanted to make a note somewhere so I wouldn't forget that that's an issue.

Not a huge issue, but it's important for completion's sake.